Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Handle errors if run_full_install fails in preflight updater #36

Open
eloquence opened this issue Nov 5, 2020 · 1 comment
Open

Handle errors if run_full_install fails in preflight updater #36

eloquence opened this issue Nov 5, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@eloquence
Copy link
Member

The run_full_install method currently runs check_call as follows:

    sdlog.info("Running sdw-admin apply")
    cmd = ["sdw-admin", "--apply"]
    subprocess.check_call(cmd)

We don't catch CalledProcessError, so if the command fails for any reason, it will raise an exception. This will cause the upgrade thread to be interrupted, but the updater will continue to run. The result from the user's point of view is a frozen updater. We should catch this error, and properly abort the update and report it.

@zenmonkeykstop
Copy link
Contributor

Still an issue, moving to securedrop-updater repo

@zenmonkeykstop zenmonkeykstop added the bug Something isn't working label Mar 30, 2023
@zenmonkeykstop zenmonkeykstop transferred this issue from freedomofpress/securedrop-workstation Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants