CI is failing for PRs to 0.12.0 branch

[emkll]

Description

Steps to Reproduce

Observe CI status of PRs that target release/0.12.0, staging-with-rebase consistently fails with

  TASK [Fail if package is missing from build dir] *******************************
    failed: [localhost] (item=securedrop-app-code_0.12.0~rc1+trusty_amd64.deb) => {"changed": false, "item": "securedrop-app-code_0.12.0~rc1+trusty_amd64.deb", "msg": "run 'make build-debs' - ../../build/trusty/securedrop-app-code_0.12.0~rc1+trusty_amd64.deb missing"}

• https://circleci.com/gh/freedomofpress/securedrop/22699
• https://circleci.com/gh/freedomofpress/securedrop/22700
• https://circleci.com/gh/freedomofpress/securedrop/22716

Comments

Local staging testing on that branch works fine, it might have something to do with the rebase logic?

[emkll]

testing fix on this branch: https://github.com/freedomofpress/securedrop/tree/testing-0.12.0-ci and this circle job: https://circleci.com/gh/freedomofpress/securedrop/22726

securedrop_app_code_deb is specified by https://github.com/freedomofpress/securedrop/blob/develop/install_files/ansible-base/group_vars/all/securedrop#L29

in develop, version distribution separated with a +: https://github.com/freedomofpress/securedrop/blob/develop/install_files/ansible-base/roles/build-securedrop-app-code-deb-pkg/files/changelog-trusty#L1
in release/0.12.0, version distribution is separated by a -:
https://github.com/freedomofpress/securedrop/blob/release/0.12.0/install_files/ansible-base/roles/build-securedrop-app-code-deb-pkg/files/changelog-trusty#L1

This error was introduced due to not modifying the logic of update-version.sh as part of #4080 , and update-version.sh was run as part of the release management process