Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep two different versions of requirements.txt file for Python2 and Python3 #4415

Closed
kushaldas opened this issue May 8, 2019 · 3 comments · Fixed by #4544
Closed

Keep two different versions of requirements.txt file for Python2 and Python3 #4415

kushaldas opened this issue May 8, 2019 · 3 comments · Fixed by #4544

Comments

@kushaldas
Copy link
Contributor

Description

pip-compile creates different output for requirements.txt for Python2 and in Python3. Which in turn creates problems in installing those dependencies in the different versions.

Probable solution

Have two different requirements files for Python2 and Python3, for both dev and tests.

@rmol
Copy link
Contributor

rmol commented Jun 18, 2019

@kushaldas Unaware of this ticket, I went down a different path trying to address this, and environment markers seemed to work. At least they let me keep Python 2 requirements in the file without breaking Python 3 usage, e.g. enum34 and ipaddress.

Are there other problems they don't cover, or might that be a solution?

@kushaldas
Copy link
Contributor Author

@rmol I will have to re-research tomorrow morning.

@rmol
Copy link
Contributor

rmol commented Jun 18, 2019

@kushaldas I'd still be interested to hear your thoughts about environment markers, but after further investigation it looks like separate requirements files will be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants