Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI branch filtering logic doesn't work from forks #4479

Closed
redshiftzero opened this issue May 29, 2019 · 0 comments · Fixed by #4505
Closed

CI branch filtering logic doesn't work from forks #4479

redshiftzero opened this issue May 29, 2019 · 0 comments · Fixed by #4505
Labels
CI-specific bug

Comments

@redshiftzero
Copy link
Contributor

Description

We heavily use Circle's branch filtering logic: https://github.com/freedomofpress/securedrop/blob/develop/.circleci/config.yml#L355

However the logic doesn't seem to be working for PRs from forks: #4475

We should revise our branch filtering rules such that the correct CI jobs run from forks (e.g. i18n anywhere in the branch name triggers the translation test job)
@redshiftzero redshiftzero mentioned this issue May 29, 2019
Merged
3 tasks
@redshiftzero redshiftzero added this to Nominated for next sprint in SecureDrop Team Board May 29, 2019
@eloquence eloquence changed the title branch filtering logic doesn't work from forks CI branch filtering logic doesn't work from forks May 30, 2019
@eloquence eloquence moved this from Nominated for next sprint to Current Sprint - 5/30-6/12 in SecureDrop Team Board May 30, 2019
@rmol rmol mentioned this issue Jun 4, 2019
Merged
1 task
@eloquence eloquence removed this from Current Sprint - 5/30-6/12 in SecureDrop Team Board Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI-specific bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add workaround for CircleCI's problems filtering from forks rmol/securedrop
1 participant
@redshiftzero