Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime i18n configuration manipulates global state #6420

Closed
cfm opened this issue May 2, 2022 · 1 comment · Fixed by #6681
Closed

runtime i18n configuration manipulates global state #6420

cfm opened this issue May 2, 2022 · 1 comment · Fixed by #6681
Labels
good first issue hackathon

Comments

@cfm
Copy link
Member

cfm commented May 2, 2022

I guess we already do this for LOCALES, but I think continuing the pattern should be accompanied by a TODO that manipulating/relying on global state is not desirable.

Originally posted by @legoktm in #6406 (comment)
@cfm cfm mentioned this issue May 3, 2022
Merged
11 tasks
@legoktm legoktm self-assigned this Nov 2, 2022
@legoktm
Copy link
Member

legoktm commented Nov 2, 2022

(This is not a good first issue yet, I will add some more detail on what the plan is to fix this before it's ready for others to take on)

@audiodude audiodude mentioned this issue Nov 13, 2022
Merged
3 tasks
@legoktm legoktm removed their assignment Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of global i18n variables audiodude/securedrop
3 participants
@legoktm @cfm @zenmonkeykstop