Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have securedrop-admin reject Submission Keys with SHA-1 signatures #6796

Closed
legoktm opened this issue May 12, 2023 · 4 comments · Fixed by #6928
Closed

Have securedrop-admin reject Submission Keys with SHA-1 signatures #6796

legoktm opened this issue May 12, 2023 · 4 comments · Fixed by #6928
Assignees

Comments

@legoktm
Copy link
Member

legoktm commented May 12, 2023

Description

securedrop-admin should reject Submission Keys that have SHA-1 signatures

https://sequoia-pgp.org/blog/2023/02/01/202302-happy-sha1-day/

We should install sq-keyring-linter as part of the Tails Admin Workstation setup, and then check the key in https://github.com/freedomofpress/securedrop/blob/develop/admin/bin/validate-gpg-key.sh, erroring if it fails the linter

@legoktm legoktm added this to the SecureDrop 2.7.0 milestone Jun 26, 2023
@rocodes rocodes self-assigned this Aug 21, 2023
@rocodes
Copy link
Contributor

rocodes commented Aug 21, 2023

We currently run all the pubkeys (submission key, ossec alert key, journalist key if applicable) through our validation script.

Question for team: Should we fail on any key using SHA-1 in its binding signature, or just on the Submission Key?

@zenmonkeykstop
Copy link
Contributor

IMO it would make sense to apply across the board.

@legoktm
Copy link
Member Author

legoktm commented Aug 23, 2023

Agreed, I think we should fail all SHA-1 signed keys. Yes, GPG will still accept them, but they're bad and we should discourage their use. Plus it should be easier to rotate OSSEC + journalist keys vs the submission key since they're not public facing.

@zenmonkeykstop
Copy link
Contributor

If we can get sq-keyring-linter added in an upcoming Tails base version - would it make sense to defer this change until then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants