Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade boxes for 1.4.0 #5329

Merged
merged 1 commit into from Jun 23, 2020
Merged

Add upgrade boxes for 1.4.0 #5329

merged 1 commit into from Jun 23, 2020

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Jun 18, 2020

Status

Ready for review

Description of Changes

Towards #5289.

Changes proposed in this pull request:

  • Adds references to new "upgrade" scenario boxes (already uploaded to S3)

Testing

  • Checkout develop
  • make build-debs
  • Check out this branch
  • make upgrade-start (will take a while as it needs to fetch the boxes)
  • source interface shows SecureDrop version 1.4.0
  • make upgrade-test-local completes without error
  • source interface shows SecureDrop version 1.5.0~rc1

Deployment

Dev only

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

@eloquence eloquence added this to In Development in SecureDrop Team Board Jun 18, 2020
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but the source interface is showing 1.3.0 after upgrade-start.

@emkll
Copy link
Contributor

emkll commented Jun 22, 2020

@kushaldas that is because molecule/shared/stable.ver on this branch still contains 1.3.0. This PR needs to be rebased on latest develop (to include changes from #5328) before it is ready for review.

@conorsch
Copy link
Contributor Author

Aye, and since #5328 is in, I'll do that now!

@conorsch conorsch marked this pull request as ready for review June 22, 2020 15:37
@conorsch conorsch requested a review from emkll as a code owner June 22, 2020 15:37
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

  • Checkout develop
  • make build-debs
  • Check out this branch
  • make upgrade-start (will take a while as it needs to fetch the boxes)
  • source interface shows SecureDrop version 1.4.0
  • make upgrade-test-local completes without error
  • source interface shows SecureDrop version 1.5.0~rc1

@kushaldas kushaldas merged commit b8fa78f into develop Jun 23, 2020
SecureDrop Team Board automation moved this from In Development to Done Jun 23, 2020
@kushaldas kushaldas deleted the upgrade-boxes-for-1.4.0 branch June 23, 2020 12:36
@eloquence eloquence mentioned this pull request Jun 23, 2020
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants