Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Load a secret "From File" in "Recover a Secret" flow #2

Closed
garrettr opened this issue Apr 20, 2016 · 1 comment
Closed

Load a secret "From File" in "Recover a Secret" flow #2

garrettr opened this issue Apr 20, 2016 · 1 comment
Assignees
Milestone

Comments

@garrettr
Copy link
Contributor

We can't load a secret from a file in the "Recover a Secret" flow.

Motivation: I want a small but non-trivial bug to work on so I can gain some experience with React and the secretshare codebase. Discussed this with @GabeIsman and agreed this was a desired feature that also fits the criteria of a good first bug. He was thinking of refactoring this into a unified "share input" component capable of handling either text input or file input. Since doing that refactor together sounds like a useful educational experience, I am going to start by doing this my (very likely to be naive and unsophisticated) way, and we can revisit refactoring after that.

@garrettr garrettr self-assigned this Apr 20, 2016
@garrettr garrettr added this to the MVP milestone Apr 20, 2016
@GabeIsman
Copy link
Contributor

This has been implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants