Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Can't run tests on Mac #31

Closed
garrettr opened this issue Jun 9, 2017 · 5 comments
Closed

Can't run tests on Mac #31

garrettr opened this issue Jun 9, 2017 · 5 comments
Labels
Milestone

Comments

@garrettr
Copy link
Contributor

garrettr commented Jun 9, 2017

I'm running the latest LTS release of Node.js:

sunder ~> node --version
v6.11.0
sunder ~> npm --version
3.10.10
@garrettr garrettr added the bug label Jun 9, 2017
@garrettr garrettr added this to the MVP milestone Jun 9, 2017
@GabeIsman
Copy link
Contributor

npm rebuild and try again? It's an electron version mismatch.

@garrettr
Copy link
Contributor Author

garrettr commented Jun 9, 2017

@GabeIsman npm rebuild did indeed fix the issue. Should we document this in the README somewhere as a potentially helpful troubleshooting step for other developers? I'm not sure how that would be best worded—what was about it that circumstance that made you think "npm rebuild" will fix this? I had already tried an rm -rf node_modules && npm install, so I'm slightly confused as to why that didn't work, but npm rebuild did.

Sorry for being such an Electron/Node n00b 😝 .

@GabeIsman
Copy link
Contributor

Any time I see a 'version mismatch' or 'binding not found' error I assume that I need to rebuild the native deps with npm rebuild.

I think we should probably be running npm rebuild in the postinstall hook, so it gets run every time you npm install. It's smart enough to not rebuild deps that don't need it, so shouldn't add too much time.

I think that npm rebuild is a fairly recent addition to the npm universe, although I'm not sure. Put this in the category of things about the development setup that should be updated to match the latest in the blindingly quick succession of JS development best practices.

Let alone that Webpack now has a completely new, non-backwards-compatible API. 🤦‍♂️

@conorsch
Copy link
Contributor

conorsch commented Jun 9, 2017

I would very much like to pin a release channel, e.g. LTS, and use that across all platforms. Then we can declare one and only one version of NodeJS in the README (since Mac users must download separately).

@GabeIsman
Copy link
Contributor

I think the root cause of this will be resolved with #38, leaving aside the issue of node versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants