-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoomer doesn't show all of the image #398
Comments
Thanks. I think it depends on where on the image you click. You'd
naturally tend to click on the area that you were interested in, though
not always.
That may just be how the library we use works, but you could try raising
an issue against https://github.com/samjonesigd/vue-image-zoomer.
…------ Original Message ------
From: "John Veness" ***@***.***>
To: "Freegle/iznik-nuxt" ***@***.***>
Cc: "Subscribed" ***@***.***>
Sent: 19/04/2022 22:21:26
Subject: [Freegle/iznik-nuxt] Zoomer doesn't show all of the image
(Issue #398)
See this video (hopefully it works, I've been having trouble with GH):
https://user-images.githubusercontent.com/2512915/164103597-770cf8ce-3eed-4f29-af61-1d7ff2ed7ce8.mp4
You may notice that I am not able to zoom into the bottom roughly
one-third of the image.
—
Reply to this email directly, view it on GitHub
<#398>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN26ABO2M5IMUPTUH2WH3VF4PVNANCNFSM5T2C2AIQ>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
|
I've tried clicking in all sorts of places, with always the same effect. I've tested with several browsers. I guess I could raise an issue there, but I suspect it will quickly get to the point where they ask how I'm using their code. As you're the direct "user" of their code, maybe you could raise an issue and answer any questions they bring up? |
What's your viewport size? |
Your viewport size is: DPR: 1.14 Screen Size: 1683 × 946 |
Thanks, I can reproduce this. I think it's the least worst option, though. The popup is scaled so that it fits the screen without scrolling. That has the consequence that you noticed. You can make zoom work to allow you to zoom at the edges, but only if you allow the image to overflow the screen and force a scroll. The combination of scroll and zoom is pretty clunky, and that would make the experience worse more of the time - people would have to scroll fairly regularly on small screens. Wanting to be able to zoom at the edges of the image is less likely (though not impossible). |
On further testing, this seems to only be a problem when there is only one image in a post. When the carousel is in use, the zooming works fine. |
That's interesting. I've done a change to put a single image inside the carousel, which will be live after around 10:30 today. Can you see if it helps? |
Yep, that seems to work fine now, thanks. |
Great - thanks for helping improve this area. |
See this video:
untitled.mp4
You may notice that I am not able to zoom into the bottom roughly one-third of the image.
The text was updated successfully, but these errors were encountered: