Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoomer doesn't show all of the image #398

Closed
JohnVeness opened this issue Apr 19, 2022 · 9 comments
Closed

Zoomer doesn't show all of the image #398

JohnVeness opened this issue Apr 19, 2022 · 9 comments

Comments

@JohnVeness
Copy link
Contributor

JohnVeness commented Apr 19, 2022

See this video:

untitled.mp4

You may notice that I am not able to zoom into the bottom roughly one-third of the image.

@edwh
Copy link
Member

edwh commented Apr 19, 2022 via email

@JohnVeness
Copy link
Contributor Author

I've tried clicking in all sorts of places, with always the same effect. I've tested with several browsers.

I guess I could raise an issue there, but I suspect it will quickly get to the point where they ask how I'm using their code. As you're the direct "user" of their code, maybe you could raise an issue and answer any questions they bring up?

@edwh
Copy link
Member

edwh commented Apr 20, 2022

What's your viewport size?

https://whatismyviewport.com/

@JohnVeness
Copy link
Contributor Author

Your viewport size is:
1419 × 796

DPR: 1.14

Screen Size: 1683 × 946

@edwh
Copy link
Member

edwh commented Apr 21, 2022

Thanks, I can reproduce this. I think it's the least worst option, though.

The popup is scaled so that it fits the screen without scrolling. That has the consequence that you noticed.

You can make zoom work to allow you to zoom at the edges, but only if you allow the image to overflow the screen and force a scroll. The combination of scroll and zoom is pretty clunky, and that would make the experience worse more of the time - people would have to scroll fairly regularly on small screens.

Wanting to be able to zoom at the edges of the image is less likely (though not impossible).

@JohnVeness
Copy link
Contributor Author

On further testing, this seems to only be a problem when there is only one image in a post. When the carousel is in use, the zooming works fine.

@edwh
Copy link
Member

edwh commented May 3, 2022

That's interesting. I've done a change to put a single image inside the carousel, which will be live after around 10:30 today. Can you see if it helps?

@JohnVeness
Copy link
Contributor Author

Yep, that seems to work fine now, thanks.

@edwh
Copy link
Member

edwh commented May 3, 2022

Great - thanks for helping improve this area.

@edwh edwh closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants