Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item promised text bubble #402

Closed
JohnVeness opened this issue Jun 18, 2022 · 3 comments
Closed

Item promised text bubble #402

JohnVeness opened this issue Jun 18, 2022 · 3 comments

Comments

@JohnVeness
Copy link
Contributor

JohnVeness commented Jun 18, 2022

Similar to #386, when you view a user profile (which shows all their Offers), or the Browse screen, and see an item has been promised to you, the text "speech bubble" when you hover over the item still says "This item has already been promised to someone. You can still reply, but you'll probably only get it if someone else drops out." rather than the new "This has been promised to you." :)

@JohnVeness JohnVeness changed the title Item promised text bubble in user profile screen Item promised text bubble Jun 18, 2022
@edwh
Copy link
Member

edwh commented Jun 22, 2022

I've made a fix for this, but I've lazily not tested it. I'll assume it works unless you tell me otherwise and reopen this issue.

@edwh edwh closed this as completed Jun 22, 2022
@JohnVeness
Copy link
Contributor Author

Hi, yes I can confirm this is working, many thanks :)

For info, I'm not able to re-open issues which you have closed, only my own issues if I closed them myself.

@edwh
Copy link
Member

edwh commented Jun 25, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants