Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the individual steps (build, install rpms, etc.) configurable #4

Closed
martbab opened this issue Oct 11, 2016 · 0 comments
Closed
Milestone

Comments

@martbab
Copy link
Contributor

martbab commented Oct 11, 2016

There is a possibility to make the individual steps run in the container configurable from the YaML file e.g. with the help of Jinja templates to handle variable expansion.

This would allow custom setups potentially useful for developers of 389-ds or Dogtag who wish to quickly test the integration of their developer work with FreeIPA.

@martbab martbab modified the milestone: v0.2 release Nov 9, 2016
martbab referenced this issue Nov 16, 2016
martbab referenced this issue Nov 16, 2016
The code was added that transforms the nested configuration into one_level
representation suitable e.g. for template substitution

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
the default config now supports individual configuration of steps that can be
executed by the container, namely:

* builddep: install missing build dependencies, if any
* configure: configure platform-specific parts of code
* lint: run 'lint' target
* build: run 'make' to build rpms/srpms/tarballs
* install_packages: install built packages
* install_server: install FreeIPA server and optional components like KRA
* run_tests: (finally) run the tests

Most of the steps can re-use constants defined in other sections via standard
Python string templating.

More info about the overriding of default step configuration will be written
in a separate document.

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
A new class was added that takes IPAContainer instance, list of command
templates and mapping with the expanded values, substitutes the commands using
the mappings and runs them succesively on the specifed container. This is the
basis for configurable command steps.

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
'cleanup' step contains commands that will be always run at the end of the
command (in the finally block)

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
Instead of hardcoding executed commands in the IPAContainer class the new
infrastructure now takes care of the processing of configured steps and
ensuring that they are run in proper order and with correctly interpolated
templates.

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
martbab referenced this issue Nov 16, 2016
The code was added that transforms the nested configuration into one_level
representation suitable e.g. for template substitution

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
the default config now supports individual configuration of steps that can be
executed by the container, namely:

* builddep: install missing build dependencies, if any
* configure: configure platform-specific parts of code
* lint: run 'lint' target
* build: run 'make' to build rpms/srpms/tarballs
* install_packages: install built packages
* install_server: install FreeIPA server and optional components like KRA
* run_tests: (finally) run the tests

Most of the steps can re-use constants defined in other sections via standard
Python string templating.

More info about the overriding of default step configuration will be written
in a separate document.

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
A new class was added that takes IPAContainer instance, list of command
templates and mapping with the expanded values, substitutes the commands using
the mappings and runs them succesively on the specifed container. This is the
basis for configurable command steps.

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
'cleanup' step contains commands that will be always run at the end of the
command (in the finally block)

https://github.com/martbab/ipa-docker-test-runner/issues/4
martbab referenced this issue Nov 16, 2016
Instead of hardcoding executed commands in the IPAContainer class the new
infrastructure now takes care of the processing of configured steps and
ensuring that they are run in proper order and with correctly interpolated
templates.

https://github.com/martbab/ipa-docker-test-runner/issues/4
@martbab martbab closed this as completed Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant