Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vylepsit prepinac mapovych vrstiev - nie je jasne aka vrstva je zvolena #19

Closed
petervojtek opened this issue Mar 4, 2017 · 8 comments
Closed
Assignees

Comments

@petervojtek
Copy link
Member

petervojtek commented Mar 4, 2017

a na mobile zostane po zmene vrstvy otvoreny prepinac vrstiev.

@petervojtek
Copy link
Member Author

petervojtek commented Mar 7, 2017

Martin @zdila , mame nejaky sposob ako pouzivat nase lokalne obrazky v scss url ?
napr. keby som chcel spravit nieco v style:

.leaflet-control-layers-toggle {
  background-image: url('ikonka-bicykla.png') !important;
}

toto je skor hypoteticka otazka -- ak to nevieme robit, tak sa bez toho zaobidem, len som bol zvedavy..

@zdila
Copy link
Member

zdila commented Mar 7, 2017

malo by to fungovat. do url(...) daj relativnu cestu k obrazku, ale malo by ist aj fm3/images/.... proste ako pri importe (require).

@petervojtek petervojtek self-assigned this Mar 8, 2017
@petervojtek
Copy link
Member Author

Martin @zdila , vdaka za pomoc, tu je zopar postrehov:

ked skusim v css toto:

url(fm3/images/icon-walk.png)

tak webpack pada s

Module not found: Error: Can't resolve './fm3/images/icon-walk.png' in '/Users/peter/repos/freemap-3-react/src/styles'
 @ ../~/css-loader!../~/sass-loader/lib/loader.js!./styles/main.scss 6:386-423

ale toto funguje:

url(../images/icon-walk.png)

dalsia vec ktora sa mi nepaci je, ze sa sa mi nepodarilo dat viac classNames nad komponent Map. ked skusim toto:

<Map className={`tool-${tool || 'none'} active-map-type-${this.props.mapType}`}

tak to pada s

class name contains HTML space characters, which are not valid in tokens

skusal som aj rozne alternativy ktore som nasiel na stackoveflow, ale nic nefungovalo (ale neskusal som riesenia s pouzitim npm pluginov urcenych na ten ucel, lebo mi prislo absurdne aby som musel pouzit npm plugin na tak trivialnu vec).

napokon som to spravi tak, ze tu moju class name nastavujem o uroven vyssie, na Row

@zdila
Copy link
Member

zdila commented Mar 8, 2017

dalsia vec ktora sa mi nepaci je, ze sa sa mi nepodarilo dat viac classNames nad komponent Map. ked skusim toto

tak neviem, ale mne to funguje a bezne to tak robim. a tu error hlasku som v zivote neidel a ani google vela vysledkov nevrati.

Inac ta ikona prepinania mapy ma vyzerat takto?

image

A !important v css zavana zlym dizajnom ;-)

@petervojtek
Copy link
Member Author

petervojtek commented Mar 8, 2017

v akom prehliadaci to mas take velke?
u mna (chrome, safari, firefox) ta ikonka je pekne naskalovana v tom obdlzniku.

ten !important som dal prec, ide to aj bez neho 633e47

@zdila
Copy link
Member

zdila commented Mar 8, 2017

chrome aj FF

@petervojtek
Copy link
Member Author

petervojtek commented Mar 8, 2017

no to je riadna zahada. tento problem:

a vzdy vidim tu istu ikonu ked prepinam typ mapy

mozes skusit restartnut webpack?

ten problem som chvilami zaznamenal aj ja ked som skusal dat mapType className nad Map (a vtedy sa ani nepropagoval typ mapy do URL). bolo to pre mna velka zahada.

tu velkost ikony by ti malo fixnut toto v main.scss:

    background-size: 29px 29px;

ale ak mas problem aj s tym ze ikona sa neprepina a restart webpacku to nevyriesi, tak to asi radsej cele revertnem, nestoji mi za to skumat prilis do detailu tento nepredvidatelny framework.

@zdila
Copy link
Member

zdila commented Mar 8, 2017

no to je riadna zahada. tento problem

sorry, to bol moj lokalny problem ked som premiestnil tu className na <Map - hned som komment zmazal.

ked mam kod 1:1 s origin, takje len ten problem s velkostou ikony. neskor sa na to pozriem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants