NAS-119610 / 23.10 / Remove unnecessary method #10302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
anodos325
approved these changes
Dec 27, 2022
themylogin
requested changes
Dec 27, 2022
yocalebo
force-pushed
the
remove-unecessary-method
branch
from
a8f1fd6
to
7b3dcb4
Compare
|
@themylogin ping now that the HA websocket connection has been fixed. snmp tests pass |
yocalebo
force-pushed
the
remove-unecessary-method
branch
3 times, most recently
from
2dd2272
to
93a1845
Compare
yocalebo
force-pushed
the
remove-unecessary-method
branch
from
93a1845
to
88a6981
Compare
themylogin
force-pushed
the
remove-unecessary-method
branch
from
e23dcea
to
e31975f
Compare
themylogin
force-pushed
the
remove-unecessary-method
branch
from
e31975f
to
a591c35
Compare
|
time 6:00 |
themylogin
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
filesystem.file_get_contentssince it doesn't have any type of validation and doesn't mix well with our rootless login functionality. This was a private method (only available across websocket connections) and was only used in our integration test suite, so I've fixed those tests accordingly.