fix(disk): Fix serial_from_device for virtio-block disks #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: #33237
william-gr
requested changes
May 15, 2018
| output = (await p1.communicate())[0].decode() | ||
| search = re.search(r'Serial Number:\s+(?P<serial>.+)', output, re.I) | ||
| if search: | ||
| return search.group('serial') |
There was a problem hiding this comment.
If smart cant be detected I would think we have to try and get the serial using geom.
virtio-block can have serials which in this case would be empty.
There was a problem hiding this comment.
@william-gr why not always use geom in the first place then?
There was a problem hiding this comment.
@themylogin because geom cannot get the serial from "especial" devices (e.g. mfid, rocket raid, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #33237