Move Create/Change Passphrase to middleware #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to add/change/remove passphrase. Ticket: #37622
Ticket: #37622
ghost
assigned 
skarekrow
suggested changes
Jul 11, 2018
| Set a passphrase in a geli | ||
| If passphrase is None then remove the passphrase | ||
| """ | ||
| if passphrase: |
There was a problem hiding this comment.
If we care about None, perhaps this check should be a bit more specific with if passphrase is None
There was a problem hiding this comment.
We dont, empty string is to be treated as none.
| self.geli_delkey(dev, GELI_RECOVERY_SLOT, force=True) | ||
| self.geli_setkey(dev, pool['encryptkey_path'], GELI_KEY_SLOT, passphrase) | ||
| finally: | ||
| if passphrase: |
skarekrow
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.