tkt-48380: Handle a None value case for serials in certs #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
bugclerk
changed the title
ghost
assigned 
sonicaj
force-pushed
the
ticket-48380
branch
2 times, most recently
from
b55d953
to
dd882a5
Compare
This commit handles a case where old certs may not have serial values set in their respective db entries. Ticket: #48380
sonicaj
force-pushed
the
ticket-48380
branch
from
dd882a5
to
df5116e
Compare
william-gr
requested changes
Sep 28, 2018
| @@ -728,6 +728,10 @@ def __create_internal(self, data): | |||
| if not verrors: | |||
| new['type'] = CERT_TYPE_EXISTING | |||
|
|
|||
| new.update(self.load_certificate(new['certificate'])) | |||
There was a problem hiding this comment.
load_certificate should be called using middleware.call because it may block.
| @@ -845,8 +849,14 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| ca_signed_certs.extend((await child_serials(ca_id))) | |||
|
|
|||
| # There is for a case when user might have old certs in the db whose serial value | |||
| # isn't set in the db | |||
| ca_signed_certs = list(filter(None.__ne__, ca_signed_certs)) | |||
There was a problem hiding this comment.
is __ne__ needed? Doesnt just None remove None from the list?
william-gr
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit handles a case where old certs may not have serial values set in their respective db entries.
Ticket: #48380