Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tkt-72097: fix traceback in pool.py #2477

Merged
merged 2 commits into from Jan 25, 2019
Merged

tkt-72097: fix traceback in pool.py #2477

merged 2 commits into from Jan 25, 2019

Conversation

yocalebo
Copy link
Contributor

william-gr
william-gr requested changes Jan 25, 2019
View reviewed changes
Copy link
Member

@william-gr william-gr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device must be None, what we want here is:

x['disk'] = RE_DISKPART.sub(r'\1', device) if device else None

@william-gr william-gr added jira and removed jira labels Jan 25, 2019
@william-gr
Copy link
Member

Thanks!

@william-gr william-gr merged commit f9da3e7 into master Jan 25, 2019
@william-gr william-gr deleted the tkt-72097 branch January 25, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-gr william-gr william-gr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yocalebo @william-gr