NAS-100103 / 11.3 / Store share ACL information persistently #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb.sharesec.getacl - returns ACL of share specified as argument 1.
smb.sharesec.setacl - sets an ACL on a share (both in share_info.tdb and cifs_share_acl)
smb.sharesec.synchronize_acls - writes the ACLs backed up in cifs_share_acl to share_info.tdb if
share_info.tdb is empty. This can happen if boot device fails or post-upgrade. Otherwise,
this call will update the database with the ACL stored in share_info.tdb if there is a
discrepency between the two.
Preference is given to the running copy of share_info.tdb because it may be modified
by SMB clients.
This script is no longer used
bugclerk
changed the title
william-gr
approved these changes
Jun 17, 2019
| @@ -1,7 +1,8 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
That shouldn't be there. :/
| async def getacl(self, share_name, options): | ||
| """ | ||
| View the ACL information for `share_name`. The share ACL is distinct from filesystem | ||
| ACLs which can be viewed by calling `filesystem,.getacl`. `ae_who_name` will appear |
| rc_acl = ' '.join([(await self._ae_to_string(i)) for i in rc_info['share_acl']]) | ||
| if rc_acl != s['share_acl']: | ||
| self.logger.debug( | ||
| 'updating stored ACL on %s to %s' % (s['name'], rc_acl) |
There was a problem hiding this comment.
debug('updating stored ACL on %s to %s', s['name'], rc_acl)
skarekrow
pushed a commit
that referenced
this pull request
Jun 26, 2019
* Make smb plugin aware of share acls
smb.sharesec.getacl - returns ACL of share specified as argument 1.
smb.sharesec.setacl - sets an ACL on a share (both in share_info.tdb and cifs_share_acl)
smb.sharesec.synchronize_acls - writes the ACLs backed up in cifs_share_acl to share_info.tdb if
share_info.tdb is empty. This can happen if boot device fails or post-upgrade. Otherwise,
this call will update the database with the ACL stored in share_info.tdb if there is a
discrepency between the two.
Preference is given to the running copy of share_info.tdb because it may be modified
by SMB clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ACL is stored in /var/db/samba4/share_info.tdb, and is used by many users to control share visibility in browse lists with the parameter "access based share enumeration". Make middleware aware of its presence and set up periodic task to synchronize the share ACL information with the freenas configuration database (if needed).