tkt-72011: Automatically enable zfsacl if sysvol supports nfs4 acls. (by anodos325) #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvol acl reset during domain provisioning can fail due to fset_nt_acl failing with NT_STATUS_INVALID_PARAMETER. This is because samba defaults to setting the acl_xattr vfs object for domain controllers unless it is explicitly overriden. During provisioning there is not a reliable mechanism to ensure that we are overriding the default with zfsacl. Instead, check for nfs4 ACL support on samba's statedir (the default location for the sysvol share), and enable zfsacl accordingly. (cherry picked from commit 5f11c84)
anodos325
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysvol acl reset during domain provisioning can fail due to
fset_nt_acl failing with NT_STATUS_INVALID_PARAMETER. This is
because samba defaults to setting the acl_xattr vfs object for
domain controllers unless it is explicitly overriden. During
provisioning there is not a reliable mechanism to ensure that
we are overriding the default with zfsacl. Instead, check for
nfs4 ACL support on samba's statedir (the default location for
the sysvol share), and enable zfsacl accordingly.