Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 59904 stable alternative solution #1734

Merged
merged 10 commits into from Mar 2, 2019

Conversation

dszidi
Copy link
Collaborator

@dszidi dszidi commented Jan 10, 2019

Since this is tricky to test I've left some debug messages in the signin component. Once the reviewer has verified this to be working I will remove the unwanted console messages for the final merging.

erincodepirate and others added 4 commits December 3, 2018 17:22
…for a match between localStorage.running_version and global variable of same name. If they don't match then an update is assumed to have occurred, and the page gets reloaded and localStorage is cleared
…se buildtime info as source of truth about update

Ticket: #59904
@erincodepirate
Copy link
Contributor

rebuild

… modifications are no longer necessary

Ticket: #59904
…e as new modifications are no longer necessary"

This reverts commit f6b362b.
Copy link
Contributor

@lola27 lola27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erincodepirate erincodepirate merged commit 2ca37b4 into freenas/11.2-stable Mar 2, 2019
@erincodepirate erincodepirate deleted the FIX-59904-STABLE-ALT branch March 2, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants