Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tests failing on mobile branch #14

Closed
desyncr opened this issue Aug 7, 2020 · 3 comments · Fixed by #24
Closed

Review tests failing on mobile branch #14

desyncr opened this issue Aug 7, 2020 · 3 comments · Fixed by #24
Assignees
Projects

Comments

@desyncr
Copy link
Collaborator

desyncr commented Aug 7, 2020

For example: https://travis-ci.org/github/desyncr/fred/jobs/710225539#L300

@desyncr desyncr created this issue from a note in Tasks (Tasks) Aug 7, 2020
@desyncr desyncr changed the title Review test failing on mobile branch Review tests failing on mobile branch Aug 7, 2020
@desyncr
Copy link
Collaborator Author

desyncr commented Aug 14, 2020

Tests are failing when calling the method: DefaultFECCodeFactory. It tries to open and parse "lib/fec.properties" file, which is not bundled in https://github.com/freenet-mobile/onion-fec but it is in https://github.com/freenet/contrib/tree/master/onion-fec (under bin/lib).

By adding lib/fec.properties test should pass. Native libraries, also contained in bin/lib should not be included.

This is a change in freenet-mobile/onion-fec project.

@desyncr desyncr self-assigned this Aug 18, 2020
@desyncr
Copy link
Collaborator Author

desyncr commented Aug 18, 2020

Include all native libraries in v0.0.4: https://github.com/freenet-mobile/onion-fec/releases/tag/v0.0.4

@desyncr
Copy link
Collaborator Author

desyncr commented Aug 19, 2020

Tasks automation moved this from Tasks to Done Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Tasks
  
Done
1 participant