Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not "hydrating" HTML with text #2

Closed
sanity opened this issue Sep 17, 2022 · 6 comments
Closed

Not "hydrating" HTML with text #2

sanity opened this issue Sep 17, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@sanity
Copy link
Contributor

sanity commented Sep 17, 2022

When I visit http://staging.freenet.org/ I momentarily just see the bullet points before the page renders properly.

Looking at the page source, it looks like the text of the HTML isn't being populated in the initial render:

   <div id="K7" class="ui text center aligned container" background-color="e8e8e8">
         <div id="K8" class="ui text left aligned container">
            <div id="K9">
               <h1 id="Ka" class="ui text"></h1>
               <h2 id="Kb" class="ui text"></h2>
            </div>
            <br id="Kc">
@sanity sanity added the bug Something isn't working label Sep 17, 2022
@Derek52
Copy link
Collaborator

Derek52 commented Sep 17, 2022

Can you take a look at this file and tell me if you see a reason this is happening? Could this be a bug in Kweb? Or, have I done something wrong? I don't see why my code would do this.

@sanity
Copy link
Contributor Author

sanity commented Sep 17, 2022

I don't see anything wrong with that code, it must be a bug in Kweb.

Element.kt#L413 is where it's supposed to update the jsoupDoc with the text if it's doing the initial rendering for the page.

Ok, I think I see the problem, the jsoupDoc != null part of this when clause should come before the browser.isCatchingOutbound() part.

Would you mind making the change and deploying a new kweb version?

@Derek52
Copy link
Collaborator

Derek52 commented Sep 17, 2022

I can do that shortly.

@sanity
Copy link
Contributor Author

sanity commented Sep 17, 2022

Hold off, that's not the fix - I'm working on it now.

@Derek52
Copy link
Collaborator

Derek52 commented Sep 17, 2022

ok

@sanity
Copy link
Contributor Author

sanity commented Sep 17, 2022

Fixed with kweb 0.12.1.

@sanity sanity closed this as completed Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants