Add 0-suffixed fields to GetIdentity.

[Thynix]

The function is also used in GetIdentitiesByScore. Addresses bug #5729.

[Bombe]

This line does not have an equivalent in your addIdentityFields() method!

[xor-freenet]

Review results (will deal with fixing them, just want to write them down first):
The old code of getIdentitiesByScore did this:
sfs.putOverwrite("Nickname" + i, identity.getNickname() != null ? identity.getNickname() : "");

Your new code does:
sfs.putOverwrite("Nickname" + suffix, identity.getNickname());

It is questionable of whether this is the same.

[xor-freenet]

More review results (will deal with fixing them, just want to write them down first):
getIdentitiesByScore iterates over a list of Score objects which it has received from the database and wants to send to the client.
Your new code does re-query each Score object from the database, which is very inefficient.

[xor-freenet]

With regards to the nickname issue: The whole rest of the FCP interface does NOT do the empty string passing if the nickname is null. So it is a good idea to change this like you did. Also, Freetalk already has a proper handler for both cases, and it is the reference implementation of a FCP client. So we can keep the nickname part.

[xor-freenet]

I've fixed the Score issue with commit e96e131

[xor-freenet]

Also please notice the improvement of commit 09d752a