Fix includes matcher for Array values
#302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code works with mocha v1.1.0:
MyClass.any_instance.expects(:my_method).with(includes([1, 2]))
MyClass.new.some_method([[1, 2], [3, 4]])
It doesn't work in v1.2.0 due to commit ff8ce38,
which changes the existing behaviour for `Array` values.
This commit reverts to the previous behaviour (only one block argument),
and adds a special case for `Hash` to match against keys.
|
@timcraft: Thanks! |
|
Any chance of getting this in a 1.2.2 release? |
|
@blimmer: Sorry. Yes, I'll try to get it deployed in the next day or two. Thanks for your patience. |
|
Awesome, thanks! |
|
Thanks a ton! 🥂 |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code works with mocha v1.1.0:
It doesn't work in v1.2.0 due to commit ff8ce38,
which changes the existing behaviour for
Arrayvalues.This commit reverts to the previous behaviour (only one block argument),
and adds a special case for
Hashto match against keys.