Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, I'm facing design issue in mobile version when tab is disabled it hides the text but not the "<li>" parent tag. #4

Closed
PathFinder5196 opened this issue Nov 2, 2017 · 5 comments

Comments

@PathFinder5196
Copy link

PathFinder5196 commented Nov 2, 2017

I've tried applying "style" tag to as well but that also seem not to be working.

@freeranger
Copy link
Owner

Hi,
I don’t know what “mobile version” you mean - there aren’t different versions of this component for mobile or not mobile.

Can you please post a link to a minimal working solution that demonstrates the problem you are having.

Thanks

@PathFinder5196
Copy link
Author

PathFinder5196 commented Nov 2, 2017

Hi,

I meant to say responsive website.
Please find screenshot for reference.

@freeranger
Copy link
Owner

Hi,

The screenshot doesnt help really I’m afraid - please post a link to a minimal working site that demonstrates the problem. You could, for example, fork my demo site as a starting point and recreate the issue in your fork: https://github.com/freeranger/react-bootstrap-tabs-demo

@PathFinder5196
Copy link
Author

@freeranger
Copy link
Owner

The style property is a react property, not a html property, so you have to supply values the react way - so style={{display:"none"}} instead of style="display:none"

You can find examples of this in the tests:
https://github.com/freeranger/react-bootstrap-tabs/blob/master/src/tests/index.js
and in the demo site:
https://github.com/freeranger/react-bootstrap-tabs-demo/blob/master/app/App.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants