Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and tune interpolator operations for create, replace and delete #94

Closed
fedefernandez opened this issue Oct 19, 2017 · 3 comments
Closed
Assignees
Milestone

Comments

@fedefernandez
Copy link
Contributor

fedefernandez commented Oct 19, 2017

The current implementation has been developed with the SELECT queries in mind. We should verify that it works for creating, replacing and deleting and create some issues for extra interpolator operations like in #93 focused on creating, replacing and deleting (maybe as[Int]?)

@FPerezP
Copy link

FPerezP commented Oct 20, 2017

We are currently supporting SELECT, INSERT, UPDATE and DELETE, but no ops to modify the schema: CREATE, TRUNCATE, ALTER, DROP.
Troy supports this OPs under a different parser. We should implement a new Interpolator to make our freestyle-cassandra library be ready for these schema operations.

I created a ticket to provide a new function for those operations returning NULL (#98)
and a different one to support schema related ops (#99)

@fedefernandez
Copy link
Contributor Author

Maybe we could rename the interpolators to ddl and dml instead of cql, what do you think?

In any case, this looks good to me.

@FPerezP
Copy link

FPerezP commented Oct 24, 2017

As we discussed by phone, IMHO, if an operation is related to Schema or Data manipulation should be transparent for the final user, so I'd keep the single cql syntax instead of splitting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants