Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: enter values outside slider limit in text box #6335

Open
lasermonkey12 opened this issue Mar 10, 2024 · 11 comments · May be fixed by #6531
Open

[feature]: enter values outside slider limit in text box #6335

lasermonkey12 opened this issue Mar 10, 2024 · 11 comments · May be fixed by #6531
Labels
💎 enhancement New feature or request

Comments

@lasermonkey12
Copy link
Contributor

What is it that you would like to see happen? 🤔

I would like to be able to type in a value for a slider that is outside the normal range (ie, range is 0 to 5 but I want -3) to set the slider to that value. This functionality existed when v3 was in alpha but went away at some point. This means that when I want values outside the range (with my user experience set to 5) I have to manually edit the url to set the value.

Additional context

There are situations where the slider values are unreasonably restrictive. For instance, I want my Aaron to have a low neck and short armscyes, which is basically the opposite of the default parameters. If I set armhole drop to 0, I still get an armhole that is nearly 8" deep when what I need for the fit I want is 6.5". I also find myself needing values outside the slider range for front armhole extra cutout (I want it above the provided range for Simon) and shoulder ease (I want it below the provided range for Simon).

@lasermonkey12 lasermonkey12 added the 💎 enhancement New feature or request label Mar 10, 2024
@woutervdub
Copy link
Contributor

I have some concern about this. Allowing just any value for certain options will result in errors. We (at least I as a developer of designs) don't test for option values that lay outside the min and max. Those errors will then be caught by the system and added as issues. I'm not sure that is a good idea.

@lasermonkey12
Copy link
Contributor Author

lasermonkey12 commented Mar 14, 2024

Maybe make it apply only to UX level 5, which is all guardrails off. The pattern is only guaranteed to work within the slider range, but there are situations (like needing a ton of back rise on Bruce and wanting fitted armholes in Aaron) where the 'allowed' range is inadequate.

@RockerKitten
Copy link

I agree with laser on this one. there's been times I've really wanted to use ranges outside of the slider. Blocks with little to no ease I know is one, I know that it will be VERY tight but to check my measurements with a sloper that's what I want. I think Bruce was another I had to get creative with just to get it to fit comfortably. I'm sure there's been other times I've lamented not being able to go outside of the slider range, and wondered why I couldn't.

@anna-puk
Copy link
Contributor

Maybe we could integrate this into the 'Edit settings by hand' dialog? It currently gives an error when you try to save with a value that's out of range, but this could be downgraded to a warning or perhaps a dialog 'do you want to continue?'

(I think this might be easier/less risky than implementing it in the usual UI, since that one responds immediately (even while typing) and this one always requires an extra confirmation in the form of pressing the 'save' button.)

@woutervdub
Copy link
Contributor

My concern is that every time an error is generated, we log an issue (see #6343). So if we allow options to be changed outside of the intended values, we will see a lot more issues being logged. And these are not 'bugs', but semi-intentional created errors. It would make it that much harder to find the things that we need to troubleshoot.

@RockerKitten
Copy link

RockerKitten commented Mar 14, 2024

Can a catch be added to the bug reporter so that any errors generated by an "out of intended value" gets discarded?
I don't know what language is used in the error reporter, but something like if slider value is greater than or less than intended range, skip error report, else generate error report.

@woutervdub
Copy link
Contributor

I don't think that's practically possible. But I'm not the person that knows these details.

@lasermonkey12
Copy link
Contributor Author

if the worry is bug reports, you'll still get them from me and anyone else who knows to edit the url. Plus the base problem of me and others not being able to make a pattern that fits properly without hacking the system remains a problem and imo goes against what freesewing is intended to be (patterns to fit all different body shapes).

@lasermonkey12
Copy link
Contributor Author

Bringing this up again, I just made a teagan where I wanted a very narrow neck hole and negative ease. I had to manually reduce measurements to make it the shape I wanted, and then I edited the URL to -10% for the neck hole size because I wanted to keep everything else the same shape (neck width is attached to hps to waist which is attached to waist to armpit which affects the armscye). It is very common for "women's" rtw t-shirts to be negative ease, but that's not possible with the current slider ranges.

@karlnippoldt
Copy link
Contributor

This is also a problem on Simon. For the button free length field, the help text says “If you want to have buttons below your waistband, you can. You should enter a negative value here, making sure it’s within the length bonus you have available.” but there is no way to actually enter a negative value.

@karlnippoldt
Copy link
Contributor

In terms of the User Experience setting, I think it makes sense to allow entering a value outside of the normal range on 4+, and display a warning if this is attempted for level 4. Since otherwise the only difference between level 4 and 5 is the “are you sure?” warnings (at least according to the documentation), for consistency, this shouldn’t be restricted to level 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants