Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Line drawings are sometimes displayed out of their box #6790

Open
HaasJona opened this issue May 22, 2024 · 1 comment
Open

[bug]: Line drawings are sometimes displayed out of their box #6790

HaasJona opened this issue May 22, 2024 · 1 comment
Labels
馃悰 bug Something isn't working

Comments

@HaasJona
Copy link
Contributor

What seems to be the problem? 馃

Depending on the screen resolution, the line drawing on the design chooser site sometimes escape their box:

grafik

This seems to happen mostly with very wide screens. I'm using 2560x1440.

Design / Plugin / Package 馃

sites/org

Additional context

No response

@HaasJona HaasJona added the 馃悰 bug Something isn't working label May 22, 2024
@joostdecock
Copy link
Member

Getting an embedded SVG to grow to fill the available space is a bit hit and miss in browsers, as SVGs do not have an explicit width or height (because that makes them responsive).

So the current implementation is a bit hackish in that is explicitly sets the width from which the height will auto-adapt.

This requires some CSS voodoo in sites/shared/components/design.mjs and while we're at it we should pick a better default image for those designs missing an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants