Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-design]: Make git optional #6827

Open
BenJamesBen opened this issue Jun 6, 2024 · 1 comment
Open

[new-design]: Make git optional #6827

BenJamesBen opened this issue Jun 6, 2024 · 1 comment
Assignees
Labels
馃摉 documentation Documentation 馃憤 good first issue An issue that you can take on without much prerequisite knowledge or experience

Comments

@BenJamesBen
Copy link
Contributor

Where can we see the problem? 馃

https://freesewing.dev/tutorials/pattern-design/part1/new-design

Suggested content

It seems that a new v3 prerequisite to running the tutorial is having the git command available. Mac and Linux come with it preinstalled, but MS Windows does not. If this is so then we should add information to the Pattern Design tutorial...

  • Specifically mention that the git command is required.
  • Add information about how Windows users can install it.

Additional context

For more information and discussion, please see:
https://discord.com/channels/698854858052075530/1248308667862749254/1248316733928771594
discord://discord.com/channels/698854858052075530/1248308667862749254/1248316733928771594

The git command is used in packages/new-design/lib/utils.mjs.

(We might also want to look at the existing git information in the Getting started on Windows tutorial to see if it is still valid.)
https://freesewing.dev/tutorials/getting-started-windows

@BenJamesBen BenJamesBen added 馃摉 documentation Documentation 馃憤 good first issue An issue that you can take on without much prerequisite knowledge or experience labels Jun 6, 2024
@joostdecock
Copy link
Member

I think the better option here is to make git optional. It's not strictly needed, so we should probably swallow that error.
I'll update the issue title accordingly

@joostdecock joostdecock changed the title [docs]: Add git command information to Pattern Design tutorial [new-design]: Make git optional Jun 12, 2024
@joostdecock joostdecock self-assigned this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃摉 documentation Documentation 馃憤 good first issue An issue that you can take on without much prerequisite knowledge or experience
Projects
None yet
Development

No branches or pull requests

2 participants