Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Undefined error for Charlie Chinos measurements #6894

Closed
joostdecock opened this issue Jun 19, 2024 · 5 comments
Closed

[bug]: Undefined error for Charlie Chinos measurements #6894

joostdecock opened this issue Jun 19, 2024 · 5 comments
Labels
🐛 bug Something isn't working needs-triage Issues that need to be triaged/labeled 🤖 robot Auto-generated issues

Comments

@joostdecock
Copy link
Member

Having saved my measurements as required for the Charlie Chinos design (https://freesewing.org/set?id=54701), when I attempt to create the design I am returned the errors below, and several screens of warnings, of which I am appending the first. It appears the parameters from the measurement set aren't being passed into the functions? Please let me know if this is a known issue, or is a workaround exists, as the concept is incredibly exciting if I can get it to work!

User 83708

@joostdecock joostdecock added 🐛 bug Something isn't working 🤖 robot Auto-generated issues needs-triage Issues that need to be triaged/labeled labels Jun 19, 2024
@IanLukeFinley
Copy link

I'm not sure the error messages properly posted from the web submission portal, so adding here as well.

Screenshot 2024-06-19 144815

Screenshot 2024-06-19 144815

@HaasJona
Copy link
Contributor

I'll look at this

@HaasJona
Copy link
Contributor

This is a duplicate of #6271. While the error handling can be improved in code, you can also work around this issue by using different measurements.

For example if you lower your seat measurements so that waist-to-seat is 10", the pattern will work okay. So I recommend to double check your measurements and follow these hints: https://freesewing.org/docs/about/faq/measurements-issues#seat-and-hips

Of course it's very possible that your measurements are correct and that the code needs to be improved.

@BenJamesBen as you were looking for a measurement set to debug the issue, this might be helpful.

@IanLukeFinley
Copy link

Thank you for the feedback. 10" in that field does resolve the issue, so I'll go back through and double check all my measurements' accuracy. I appreciate your swift response!

@HaasJona
Copy link
Contributor

HaasJona commented Jun 23, 2024

I'll close this issue as a duplicate. The pull request #6901 should fix this crash in the future and warn the user about their potentially incorrect measurements. However feel free to give us an update if you've verified that your measurements are indeed correct and you think the problem is in the pattern.

Thanks for the good bug report.

@HaasJona HaasJona closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working needs-triage Issues that need to be triaged/labeled 🤖 robot Auto-generated issues
Projects
None yet
Development

No branches or pull requests

3 participants