Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrocompatibility issue with automatic contact generation in invite #52

Open
flaviogrossi opened this issue Mar 5, 2021 · 0 comments

Comments

@flaviogrossi
Copy link
Contributor

flaviogrossi commented Mar 5, 2021

We are having issues using this library with software previously compiled using the original sofia-sip hosted at sourceforge.

In particulare there is an issue with automatic contact generation during an invite. It seems that commit afb119a is not retrocompatible and broke some existing software. Also, it seems to go against the documentation which states that a contact header is generated if the library user does not provide one esplicitly and does not pass the SIPTAG_CONTACT(NULL) option.

One example is the janus webtrc gateway which seems to not be compatible with this repo, while working with the original sofia-sip library. This is the relevant issue. The problem there is that the contact header is now missing, since it relied on the sofia stack to automatically generate it (as per the docs). Everything is fixed by reverting the aformentioned commit.

Any thoughts? What is the rationale of the change?

Thanks

EDIT: this is related to #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant