Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V.17 fixed point issues #53

Closed
lexxer3d opened this issue Jul 11, 2023 · 3 comments
Closed

V.17 fixed point issues #53

lexxer3d opened this issue Jul 11, 2023 · 3 comments

Comments

@lexxer3d
Copy link

Hi!

I've found the following issues while testing V.17 14400 TCF with fax_decode tool when compiled with fixed point support:

  1. v17rx.c is missing SPANDSP_USE_FIXED_POINTx
  2. int32 overflow happens for s->training_error, long training threshold (line 961) and training succeeded threshold (line 1139).

Suggested fix with TCF sample is attached.
v17_fixedp.zip

@coppice-git
Copy link
Collaborator

I have commited this change. I haven't really been keeping the fixed point stuff up to date, as nobody seemed to care about it. May I ask what platform you are using the fixed point code on? Do you have problems with the other modems? The last time I remember looking at the fixed point stuff I thought there were still multiple scaling issues in the modems.

@lexxer3d
Copy link
Author

It's armv7l. Btw, even with the fix it doesn't work fine, so I switched to float point.
Tried two different modems.

@lexxer3d
Copy link
Author

Fixed in commit 239bf2f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants