Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imposible to remove saved video #46

Closed
dimqua opened this issue Mar 13, 2018 · 3 comments
Closed

Imposible to remove saved video #46

dimqua opened this issue Mar 13, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@dimqua
Copy link

dimqua commented Mar 13, 2018

I can't delete saved video from the list. I can only remove all of them. Version 0.1.3-beta.

@PrestonN PrestonN added the bug Something isn't working label Mar 14, 2018
@PrestonN
Copy link
Member

I've just confirmed this bug. I will make sure it is fixed before the next release. Thanks for the report.

@NathenL
Copy link

NathenL commented Mar 14, 2018

Looking into this. When displayVideo() is called it is passed a listType of, 'history' so it thinks you are on the history page when you try to remove a video and not the saved videos page. Thus tries to call,

deleteHtml = '<i onclick="removeFromHistory(\'' + videoId + '\'); showHistory()" class="videoDelete fas fa-times"></i>';

which does not exist in the history .db and nothing happens.

NathenL added a commit to NathenL/FreeTube that referenced this issue Mar 15, 2018
Simple fix to remove typo and some cleanup
PrestonN pushed a commit that referenced this issue Mar 15, 2018
Simple fix to remove typo and some cleanup
@PrestonN
Copy link
Member

Fixed as of #54. Closing issue.

weblate pushed a commit to weblate/FreeTube that referenced this issue Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants