Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogenerate trap list [bounty: 6 XTR] #2295

Closed
DreadKnight opened this issue May 14, 2023 · 1 comment
Closed

autogenerate trap list [bounty: 6 XTR] #2295

DreadKnight opened this issue May 14, 2023 · 1 comment
Labels
bounty Some amount of our token, XatteR, is offered brainstorm Still need to figure out details about this coding This issue requires some programming invalid The issue is not from the project or a "won't fix" pipeline Affects how the project is being developed priority This should get fixed as soon as possible!
Milestone

Comments

@DreadKnight
Copy link
Member

DreadKnight commented May 14, 2023

List of traps should be autogenerated from the ability files when building the game.
We had manual list for units before and it was awful to deal with.
Somewhat related to issue #2294, but probably a bit trickier overall.

The list could be generated from traps assets provided we move them to own folder, something like assets/traps and we could even remove unit names from their filenames (provided its not a bad idea, harder to keep track of what's what), though hopefully this will work fine down the line (need to consider having animated sprites or multiple sprites for traps). Remaining stuff sprites from the folder are actually projectiles; guess at some point we'll also have traps that will act as projectiles (move given time), because there are always exceptions to the rules when it comes to AB, total madness...

Alternatively or complementary we could have ability files define the stuff and when building game, we would have a script scanning those files to compile a list.

@DreadKnight DreadKnight added coding This issue requires some programming priority This should get fixed as soon as possible! pipeline Affects how the project is being developed bounty Some amount of our token, XatteR, is offered labels May 14, 2023
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone May 14, 2023
@DreadKnight DreadKnight added the brainstorm Still need to figure out details about this label May 14, 2023
@DreadKnight
Copy link
Member Author

Seems there's no more need, at least for now, as there's no longer a manually maintained list.
https://github.com/FreezingMoon/AncientBeast/blob/master/src/utility/trap.ts

@DreadKnight DreadKnight added the invalid The issue is not from the project or a "won't fix" label May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Some amount of our token, XatteR, is offered brainstorm Still need to figure out details about this coding This issue requires some programming invalid The issue is not from the project or a "won't fix" pipeline Affects how the project is being developed priority This should get fixed as soon as possible!
Projects
None yet
Development

No branches or pull requests

1 participant