Support multi checkbox group

[brunolemos]

<input type="checkbox" name="enabled_features[]" value="featureA" checked />Feature A<br />
<input type="checkbox" name="enabled_features[]" value="featureB" />Feature B<br />
<input type="checkbox" name="enabled_features[]" value="featureC" />Feature C<br />

Expected Result

{
  "enabledFeatures": ["featureA"]
}

or

{
  "enabledFeatures": {
    "featureA": true,
    "featureB": false,
    "featureC": false
  }
}

Current Result

{
  "enabledFeatures[]": true
}

This is common at least when I was in the php world a few years ago:
https://gist.github.com/southern-hu/5424068
http://www.wastedpotential.com/html-multi-checkbox-set-the-correct-way-to-group-checkboxes/

[fregante]

That sounds like a good idea. PR welcome to implement it as an array:

{
  "enabledFeatures": ["featureA"]
}

[AndersDJohnson]

We could consider using something like form-serialize.

[fregante]

That's not a terrible idea, it would free webext-options-sync from doing any form parsing, however we still need an unserialize version to apply the data back to the form.

[AndersDJohnson]

@bfred-it Good point. Looks like there is a fork of it (form-serialization) that supports deserialization, though I found a more widely used one that supports both serialize and deserialize: dom-form-serializer.

[fregante]

Amazing, thanks! Could you send a PR for that?

[fregante]

A build step is coming in #20 so it will be easier to integrate this.

[AndersDJohnson]

@bfred-it Thanks, let me know when that's in?

[fregante]

It's in!

[fregante]

Can you test #28 out with:

npm install webext-options-sync@next

You can then verify the stored data with chrome.storage.sync.get(console.log). You'll also see that default's aren't included (except the arrays/object that are now possible thanks to that module)