Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Regex doesn't allow numbers but example contains numbers #21

Closed
drscream opened this issue Nov 10, 2015 · 2 comments
Closed

Regex doesn't allow numbers but example contains numbers #21

drscream opened this issue Nov 10, 2015 · 2 comments

Comments

@drscream
Copy link

The regular expression which check the ID does not allow numbers (https://github.com/freifunk-berlin/ca.berlin.freifunk.net/blob/master/app.py#L47). But the example text contains numbers:

Ein kurzer und eindeutiger Name für deinen Zugang (z.B. funkenpumpe oder hermannstr42_vh). Bitte nur Kleinbuchstaben und Bindestriche verwenden.

The same issue is the underscore in the example, which is not allowed based on the error message displayed:

Must be lowercase and can contain '-'

I'm not sure if the example text is wrong or the regex so I didn't open a pull request yet.

@ffcb
Copy link
Contributor

ffcb commented Nov 17, 2015

the examples were changed 7 days ago (https://github.com/freifunk-berlin/ca.berlin.freifunk.net/blob/master/templates/index.html)
to fit the new text i created the pullrequest #30 to update the validator

@booo
Copy link
Member

booo commented Nov 19, 2015

Should be fixed with the latest merge. Thanks @ffcb for the implementation!

@booo booo closed this as completed Nov 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants