Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Naming refactoring #39

Closed
MyIgel opened this issue Sep 10, 2023 · 1 comment
Closed

[RFC] Naming refactoring #39

MyIgel opened this issue Sep 10, 2023 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@MyIgel
Copy link
Member

MyIgel commented Sep 10, 2023 •
edited
Loading

The current code base hides any valuable information what a variable eventually does behind a mostly one character name.
The fact that there are no type hints on parameters makes development and debugging much harder than it should be.

I would propose to do a bigger "rewording" in which most (if not all) variables are renamed.
By using more useful type hints (TypeScrtipt anyone? -> #52) make the whole source code easier to understand (might be a good idea to fix #13 (Migrate away from Gulp) before it to have a clean build env).
@MyIgel MyIgel added enhancement New feature or request question Further information is requested labels Sep 10, 2023
@MyIgel MyIgel pinned this issue Sep 17, 2023
@weeman1337 weeman1337 mentioned this issue Oct 5, 2023
Closed
@MyIgel
Copy link
Member Author

MyIgel commented Oct 26, 2023

Closed by #63

@MyIgel MyIgel closed this as completed Oct 26, 2023
@skorpy2009 skorpy2009 unpinned this issue Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MyIgel