Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing services does blocking I/O in the event loop #681

Closed
bdraco opened this issue Mar 26, 2024 · 0 comments · Fixed by #722
Closed

Importing services does blocking I/O in the event loop #681

bdraco opened this issue Mar 26, 2024 · 0 comments · Fixed by #722

Comments

@bdraco
Copy link

bdraco commented Mar 26, 2024

What version of Spook are you using?

n/a

What version of Home Assistant are you using?

dev

The problem

module = importlib.import_module(f".{module_path}", __package__)

https://github.com/home-assistant/core/blob/3f545cb3d368a0ea046603e0120f42883187d02f/homeassistant/helpers/importlib.py#L27 could be used but there is no risk of something else loading the same code so loading it in the single default executor job is likely the simplest solution

Screenshot 2024-03-25 at 10 00 14 PM

Anything in the logs? Paste it here!

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant