Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align code needs to be updated #8

Open
Spuds opened this issue Mar 28, 2022 · 1 comment
Open

Align code needs to be updated #8

Spuds opened this issue Mar 28, 2022 · 1 comment

Comments

@Spuds
Copy link

Spuds commented Mar 28, 2022

See Spuds@bc34357

A couple of minor things .. left and right are unique BBC codes not part of align= as such those props objects need to be updated.

In seeing that, center is also a div class not a span align. Yes this is not HTML correct, center is not a block element, but as far as the user is concerned when using the editor, center is a block element and that is how ElkArte deals with it. Check the years of defending the way center worked vs left/right.

TLDR, we need to check for the centertext class in the div section and not the span section

Updated the checkCSSProps function to able to check for a class name by setting isClass value of the passed object. This allowed the consolication of centertext and tt items.

The above should be clear in the code and is 1.1 valid, hence the issue.

@Frenzie
Copy link
Owner

Frenzie commented Mar 28, 2022

Yes, I'd noticed it needed some updates. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants