InformativeSample results in an error (InformativePairs not working anymore?)

[Theagainmen]

The problem

The InformativeSample.py doesn't work anymore, it results in errors for backtesting and plotting, both different errors.

System specs

• Windows 10 Python 3.7 64-bit
• Freqtrade version: freqtrade develop-1d18e0a1
• Link to the InformativeSample.py: https://github.com/freqtrade/freqtrade-strategies/blob/master/user_data/strategies/InformativeSample.py

Backtesting

• The command I run: freqtrade backtesting -c InformativeSample
• The error: TypeError: get_pair_dataframe() got an unexpected keyword argument 'ticker_interval'
• Full error: https://pastebin.com/E82ahrVK

Plotting

• The command I run: freqtrade plot-dataframe -s InformativeSample -p MTH/BTC --timerange=20191105-20191120
• The error: AttributeError: 'InformativeSample' object has no attribute 'dp'
• Full error: https://pastebin.com/r0P1S08J

[xmatthias]

it's fun to move issues around it sems 😆

the issue is due to the change in kwarg - best replace ticker_interval= with timeframe= short-term (we'll fix it in this repo soon).

[hroff-1902]

it's fun to move issues around it sems 😆

Yeah, "I like to move it, move it..." 😆

the issue is due to the change in kwarg - best replace ticker_interval= with timeframe= short-term (we'll fix it in this repo soon).

It's for the first reported point. What about the second one?

[xmatthias]

the 2nd problem is that it's not there as attribute (currently it's only available for type-hinting ...).

it can be fixed by assigning "None" in interface.py to dp...
or by adding dp within plotting.py/init_plotsccript() ...
either empty, or as fully instantiated dataprovider (look at backtesting.py on how).

I'm not a fan of the 2nd one since datprovider requires exchange to be initialized, which is not necessary for plotting otherwise, and self.dp is checked for existence in all our docs, so the assumption is that it can be "gone".

[Theagainmen]

the issue is due to the change in kwarg - best replace ticker_interval= with timeframe= short-term (we'll fix it in this repo soon).
This fixes the issue for backtesting :).

For plotting I tried it can be fixed by assigning "None" in interface.py to dp...

This is the only dp: in the interface.py, changing DataProvider to None didn't work, it resulted in the same error. (I'm not sure if that's what you meant though).

[hroff-1902]

@Theagainmen see the changes made in freqtrade/freqtrade#2560

the second part is to be fixed in the freqtrade codebase. That's why I transferred this issue to that github repo first...

[xmatthias]

fixed via combination of freqtrade/freqtrade#2560 and #52