Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to add custom pairlist filters and protections without changing the freqtrade sourcecode #4477

Open
MrKrautee opened this issue Mar 3, 2021 · 5 comments
Labels
Enhancement Enhancements to the bot. Get lower priority than bugs by default. Pairlist Issues / PR's related to Pairlists / pairlist handling

Comments

@MrKrautee
Copy link
Contributor

Its not really practical to add custom pairlist filters to freqtrade sources (ie: freqtrade/constants.py).

There should be the possibility to add custom pairlist filters and protections without changing the freqtrade source.

I suggest to add a new folder user_data/plugins for custom plugins.

@MrKrautee MrKrautee changed the title possibility to add custom pairlist filters and protections without change the freqtrade sourcecode possibility to add custom pairlist filters and protections without changing the freqtrade sourcecode Mar 3, 2021
@xmatthias
Copy link
Member

well the point on having a fixed list is to allow config validation - to tell you if you misspelled a protection, or whatever.

removing that is a possibility - but currently, plugins are not meant to be user-extended on purpose.

Especially for protections - it's still marked as beta feature - which means the interface to these methods can change at any time.
Making this "user-specified" means the interface cannot change anymore easily as otherwise, an update would break your custom-made protections.

I also don't think that writing custom protections / filters is something people will do very often - and the documentation for doing so is in the developer / contributor section - so when writing it, contributing it to freqtrade should clearly be the goal (i don't think you can do too many "secret sauce" things to either of the two which would put you at a disadvantage if you shared it).

@xmatthias xmatthias added Pairlist Issues / PR's related to Pairlists / pairlist handling Question Questions - will be closed after some period of inactivity. labels Mar 4, 2021
@xmatthias xmatthias added Enhancement Enhancements to the bot. Get lower priority than bugs by default. and removed Question Questions - will be closed after some period of inactivity. labels May 21, 2021
@bzed
Copy link
Contributor

bzed commented May 27, 2021

Actually I've just written a Pairlist plugin (nothing special, binance specific, but attached just in case somebody is looking for it) after some discussion in #strategy-chat. It would be really nice to be able to have some working plugin mechanism there.
Verifying the config could be done by trying to import the plugins and if that succeeds, go on.

https://gist.github.com/bzed/84775b495d553130cc2e0655a4d92306

@bibinvargheset
Copy link

Simillary, if there was a turnover pairlist it would be great, taking into account the volume and the traded price.

@hotrungnhan
Copy link

hotrungnhan commented Jan 11, 2024

+1 I think the filter is important. can select the right pairs to trade.
For example, we could sort the pair by (current-min/min) with a lower refresh time to get all of the bottom pairs that will have a higher chance of rising.

@simwai
Copy link
Contributor

simwai commented May 22, 2024

That would be cool for blacklisting new announced delisting pairs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancements to the bot. Get lower priority than bugs by default. Pairlist Issues / PR's related to Pairlists / pairlist handling
Projects
None yet
Development

No branches or pull requests

7 participants
@bzed @xmatthias @simwai @MrKrautee @hotrungnhan @bibinvargheset and others