Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcesell is not working #16

Closed
vertti opened this issue Sep 8, 2017 · 3 comments
Closed

Forcesell is not working #16

vertti opened this issue Sep 8, 2017 · 3 comments

Comments

@vertti
Copy link
Member

vertti commented Sep 8, 2017

Forcesell command executes the sell correctly but then the trade handling loop continues like the sell never happened:

2017-09-08 18:59:47,133 - rpc.telegram - INFO - Executing handler: _forcesell for chat_id: --removed--
2017-09-08 18:59:48,989 - rpc.telegram - INFO - *BITTREX:* Selling [BTC/NXS](https://bittrex.com/Market/Index?MarketName=BTC-NXS) at rate `0.000716 (profit: -0.44%)`
2017-09-08 18:59:54,339 - main - DEBUG - Handling open trade Trade(id=1, pair=BTC_NXS, amount=4.169098640873843, open_rate=0.00071958, open_since=225.63) ...
2017-09-08 18:59:55,134 - main - DEBUG - Threshold not reached. (cur_profit: -0.44%)

Checking Bittrex, the sell went through but that last line (Handling open trade) keeps appearing. As the forcesell operation does nothing else than call bittrex and update the persistence, I have a feeling that #10 might have broken it.

@gcarq
Copy link
Member

gcarq commented Sep 8, 2017

I'm implementing a test for forcesell on develop right now, lets see if I can reproduce it.

@shusso
Copy link
Member

shusso commented Sep 8, 2017

@gcarq most likely I broke it with #10 Let me know if you need me to revert it

@gcarq
Copy link
Member

gcarq commented Sep 8, 2017

The linked commit should fix this issue. I think manually flushing has to be done when writing data on a different thread, it seems that autoflush has no effect here.

@gcarq gcarq closed this as completed in 09e4c68 Sep 10, 2017
berlinguyinca referenced this issue in nullart/freqtrade Jun 14, 2018
Update from upstream repo gcarq/freqtrade@develop
LoveIsGrief added a commit to LoveIsGrief/freqtrade that referenced this issue Nov 21, 2021
The tests aren't stable and an attempt to stabilize them will be done in freqtrade#16
LoveIsGrief added a commit to LoveIsGrief/freqtrade that referenced this issue Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants