Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I try to convert Predictive Ranges [LuxAlgo] to the py, whats the problem? #358

Closed
kaanguven opened this issue Aug 17, 2023 · 7 comments
Closed
Labels
pinescript Indicators to be converted from pinescript question Further information is requested

Comments

@kaanguven
Copy link

kaanguven commented Aug 17, 2023

closed

@xmatthias xmatthias added the question Further information is requested label Aug 17, 2023
@xmatthias
Copy link
Member

Well without actually knowing where you suspect that the problem is (or what problem you're encountering) - it's pretty difficult to say.

One thing that i can see from afar is that the way you implement it will be very slow, as it's looping through the whole dataframe - but at first glance - for no good reason (it could be probably vectorized by using appropriate pandas calls).

@kaanguven
Copy link
Author

Well without actually knowing where you suspect that the problem is (or what problem you're encountering) - it's pretty difficult to say.

One thing that i can see from afar is that the way you implement it will be very slow, as it's looping through the whole dataframe - but at first glance - for no good reason (it could be probably vectorized by using appropriate pandas calls).

I guess the problem is in for loop, I'm undecided whether to use a for loop for the avg value

@xmatthias
Copy link
Member

xmatthias commented Aug 17, 2023

Well if i'm honest, i dont' see a question in any of your comments.

it's just a "this is code, this is my converted code" ... but if there's no actual question - then there's no actual response.
Please understand that i'll not be debugging random code without even knowing why or what to look for.

@kaanguven
Copy link
Author

Well if i'm honest, i dont' see a question in any of your comments.

it's just a "this is code, this is my converted code" ... but if there's no actual question - then there's no actual response. Please understand that i'll not be debugging random code without even knowing why or what to look for.

the question is : "According to pinescript, the output in my python code is wrong, what am I missing?"

@xmatthias
Copy link
Member

Well - most likely, precise understanding of how the indicator should actually work?

Pinescript seems simple at first glance, but really isn't, and i find it never really clear if something is a series or a value/scalar - as that can somehow change throughout time iirc.

Can you define (in words, not code) how the indicator should actually work?
Without that understanding, the attempt to convert it to a different language will certainly fail.

@stash86
Copy link
Contributor

stash86 commented Aug 20, 2023

Just to add one thing for you to consider, have you ever consider that maybe the pinescript's result is the one wrong?

@kaanguven
Copy link
Author

Just to add one thing for you to consider, have you ever consider that maybe the pinescript's result is the one wrong?

No 100% sure it works fine.

@xmatthias xmatthias added the pinescript Indicators to be converted from pinescript label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinescript Indicators to be converted from pinescript question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants