Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with PMAX indicator #412

Closed
aloksaurabh opened this issue Feb 5, 2024 · 1 comment
Closed

Issues with PMAX indicator #412

aloksaurabh opened this issue Feb 5, 2024 · 1 comment
Labels
question Further information is requested

Comments

@aloksaurabh
Copy link

  File "C:\Users\eye\freqtrade\user_data\strategies\MacheteV8b_alok.py", line 303, in get_buy_signal_indicators
    dataframe = PMAX(dataframe, period=10, multiplier=3, length=10, MAtype=9, src=2)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\eye\miniconda3\envs\freqtrade\Lib\site-packages\technical\indicators\indicators.py", line 1159, in PMAX
    df["basic_ub"] = df[mavalue] + (multiplier * df[atr])
                     ~~^^^^^^^^^
  File "C:\Users\eye\miniconda3\envs\freqtrade\Lib\site-packages\pandas\core\frame.py", line 4090, in __getitem__
    indexer = self.columns.get_loc(key)
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\eye\miniconda3\envs\freqtrade\Lib\site-packages\pandas\core\indexes\base.py", line 3809, in get_loc
    raise KeyError(key) from err
KeyError: 'MA_9_10'

My package list

(freqtrade) PS C:\Users\eye\freqtrade> conda list -n freqtrade
# packages in environment at C:\Users\eye\miniconda3\envs\freqtrade:
#
# Name                    Version                   Build  Channel
aiodns                    3.1.1                    pypi_0    pypi
aiofiles                  23.2.1                   pypi_0    pypi
aiohttp                   3.9.3                    pypi_0    pypi
aiosignal                 1.3.1                    pypi_0    pypi
annotated-types           0.6.0                    pypi_0    pypi
anyio                     4.2.0                    pypi_0    pypi
arrow                     1.3.0                    pypi_0    pypi
ast-comments              1.2.1                    pypi_0    pypi
attrs                     23.2.0                   pypi_0    pypi
blosc2                    2.5.1                    pypi_0    pypi
bzip2                     1.0.8                he774522_0
ca-certificates           2023.12.12           haa95532_0
cachetools                5.3.2                    pypi_0    pypi
ccxt                      4.2.35                   pypi_0    pypi
certifi                   2024.2.2                 pypi_0    pypi
cffi                      1.16.0                   pypi_0    pypi
charset-normalizer        3.3.2                    pypi_0    pypi
click                     8.1.7                    pypi_0    pypi
colorama                  0.4.6                    pypi_0    pypi
cryptography              42.0.2                   pypi_0    pypi
datetime                  5.4                      pypi_0    pypi
fastapi                   0.109.2                  pypi_0    pypi
finta                     1.3                      pypi_0    pypi
freqtrade                 2024.1                   pypi_0    pypi
frozenlist                1.4.1                    pypi_0    pypi
greenlet                  3.0.3                    pypi_0    pypi
h11                       0.14.0                   pypi_0    pypi
httpcore                  1.0.2                    pypi_0    pypi
httpx                     0.25.2                   pypi_0    pypi
idna                      3.6                      pypi_0    pypi
janus                     1.0.0                    pypi_0    pypi
jinja2                    3.1.3                    pypi_0    pypi
joblib                    1.3.2                    pypi_0    pypi
jsonschema                4.21.1                   pypi_0    pypi
jsonschema-specifications 2023.12.1                pypi_0    pypi
libffi                    3.4.4                hd77b12b_0
markdown-it-py            3.0.0                    pypi_0    pypi
markupsafe                2.1.5                    pypi_0    pypi
mdurl                     0.1.2                    pypi_0    pypi
msgpack                   1.0.7                    pypi_0    pypi
multidict                 6.0.5                    pypi_0    pypi
ndindex                   1.7                      pypi_0    pypi
numexpr                   2.9.0                    pypi_0    pypi
numpy                     1.26.3                   pypi_0    pypi
openssl                   3.0.12               h2bbff1b_0
orjson                    3.9.13                   pypi_0    pypi
packaging                 23.2                     pypi_0    pypi
pandas                    2.2.0                    pypi_0    pypi
pandas-ta                 0.3.14b0                 pypi_0    pypi
pip                       24.0                     pypi_0    pypi
pip-review                1.3.0                    pypi_0    pypi
prompt-toolkit            3.0.36                   pypi_0    pypi
psutil                    5.9.8                    pypi_0    pypi
py-cpuinfo                9.0.0                    pypi_0    pypi
py-find-1st               1.1.6                    pypi_0    pypi
pyaml                     23.12.0                  pypi_0    pypi
pyarrow                   15.0.0                   pypi_0    pypi
pycares                   4.4.0                    pypi_0    pypi
pycoingecko               3.1.0                    pypi_0    pypi
pycparser                 2.21                     pypi_0    pypi
pydantic                  2.6.0                    pypi_0    pypi
pydantic-core             2.16.1                   pypi_0    pypi
pygments                  2.17.2                   pypi_0    pypi
pyjwt                     2.8.0                    pypi_0    pypi
python                    3.11.7               he1021f5_0
python-dateutil           2.8.2                    pypi_0    pypi
python-rapidjson          1.14                     pypi_0    pypi
python-telegram-bot       20.7                     pypi_0    pypi
pytz                      2024.1                   pypi_0    pypi
pyyaml                    6.0.1                    pypi_0    pypi
questionary               2.0.1                    pypi_0    pypi
referencing               0.33.0                   pypi_0    pypi
requests                  2.31.0                   pypi_0    pypi
rich                      13.7.0                   pypi_0    pypi
rpds-py                   0.17.1                   pypi_0    pypi
schedule                  1.2.1                    pypi_0    pypi
scikit-learn              1.4.0                    pypi_0    pypi
scikit-optimize           0.9.0                    pypi_0    pypi
scipy                     1.12.0                   pypi_0    pypi
sdnotify                  0.3.2                    pypi_0    pypi
setuptools                69.0.3                   pypi_0    pypi
six                       1.16.0                   pypi_0    pypi
sniffio                   1.3.0                    pypi_0    pypi
sqlalchemy                2.0.25                   pypi_0    pypi
sqlite                    3.41.2               h2bbff1b_0
starlette                 0.36.3                   pypi_0    pypi
ta-lib                    0.4.28                   pypi_0    pypi
tables                    3.9.2                    pypi_0    pypi
tabulate                  0.9.0                    pypi_0    pypi
technical                 1.4.2                    pypi_0    pypi
threadpoolctl             3.2.0                    pypi_0    pypi
tk                        8.6.12               h2bbff1b_0
types-python-dateutil     2.8.19.20240106          pypi_0    pypi
typing-extensions         4.9.0                    pypi_0    pypi
tzdata                    2023.4                   pypi_0    pypi
urllib3                   2.2.0                    pypi_0    pypi
uvicorn                   0.27.0.post1             pypi_0    pypi
vc                        14.2                 h21ff451_1
vs2015_runtime            14.27.29016          h5e58377_2
wcwidth                   0.2.13                   pypi_0    pypi
websockets                12.0                     pypi_0    pypi
wheel                     0.42.0                   pypi_0    pypi
xz                        5.4.5                h8cc25b3_0
yarl                      1.9.4                    pypi_0    pypi
zlib                      1.2.13               h8cc25b3_0
zope-interface            6.1                      pypi_0    pypi
(freqtrade) PS C:\Users\eye\freqtrade>

Tried older pandas versions. Issue still persists.

@xmatthias xmatthias added the question Further information is requested label Feb 5, 2024
@xmatthias
Copy link
Member

Type=9 (Zema) was removed in #356 - as it's implementation was identical to Dema (and was wrongly addressed as zema).

MAType=2 should give you the same results.
we'll also slightly improve the user interface here - so the error is more meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants