Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tools>Music View>Remember view settings per document" doesn't retain pane sizes of each document #1247

Open
uliska opened this issue Jan 12, 2020 · 22 comments
Labels

Comments

@uliska
Copy link
Collaborator

uliska commented Jan 12, 2020

Reported by a user (and confirmed by me):

Howdy Frescobaldi users -- after a recent update to v3 and v3.1, the music view now defaults to 100%. It did not use to do this. Everytime I open a score, I now have to set the view to Page or Width, etc. I cannot find a Configuration option to tell Music View my preferred view (Page).

Am I missing something?

Thanks.

@uliska uliska added the defect label Jan 12, 2020
@wbsoft
Copy link
Collaborator

wbsoft commented Jan 12, 2020

Use Music->Save current view settings as default.
In the preferences Tools->Music View you can enable/disable remembering settings per-document.

@skiasaurus
Copy link

In the preferences Tools->Music View you can enable/disable remembering settings per-document.

I have that option selected, but when I close Frescobaldi and then reopen the document I was working on, it reverts to the program default.

@fedelibre fedelibre changed the title Music view doesn't save zoom level "Tools>Music View>Remember view settings per document" doesn't work anymore Feb 27, 2023
@fedelibre
Copy link
Member

I've just verified on version 3.2 and both the preference option and the menu settings don't work.

@papioara
Copy link
Contributor

I can in part confirm fedelibre's comment., although his complaint seems to be more about other mujsic view aspects here like page settings (width/height).

My complaint, though, is not about this. The above-mentioned settings are definitely remembered, but my problem is the width of the right subwindow of Frescobaldi, which on every launch has to be readjusted. The ratio on startup is always about 2/3 editor subwindow and 1/3 music view subwindow. I cannot find any setting or switch or menu entry where my preferred ratio (half and half editor and music view) can be defined, set or saved.

Any advice?

@fedelibre
Copy link
Member

You are right.
I'm now testing Frescobaldi current master and it seems that the issue described initially (width setting of each document/tab not remembered) has been fixed: if I set a document to Width instead of the default 100, Width is retained.

I confirm that the panes (what you call subwindows) width is not retained. It's what the tooltip calls "its own layout setting":

"If checked, every document in the Music View will remember its\n"
"own layout setting, zoom factor, etc. If unchecked, the View will\n"
"not change its settings when a different document is displayed."

@fedelibre fedelibre changed the title "Tools>Music View>Remember view settings per document" doesn't work anymore "Tools>Music View>Remember view settings per document" doesn't retain pane sizes of each document Feb 27, 2023
@papioara
Copy link
Contributor

I have the impression that we are not talking about the same thing yet, but with all these different terms (and maybe I use mine in a way prone to misunderstandings) it is not so easy.

In order to illustrate better what I am talking about, I attach two screenshots. The first one shows the Frescobaldi window in full-screen mode (which I always use for obvious reasons) after every startup. The second one shows what I want to have, and what Frescobaldi seems to 'forget' as soon as I close it (and that did not happen in earlier versions).

Arbeitsfläche 1_001
Arbeitsfläche 1_002

@fedelibre
Copy link
Member

Yes, I did understand your issue. To summarize, the pane sizes are not retained:

  • when moving from one document/tab to another
  • when closing and reopening Frescobaldi

Two symptoms of the same problem, I guess.

I cannot remember if it used to work, but if you are sure that it used to work in the past, then maybe something has changed in Qt and Frescobaldi source has not been updated to adapt to this change. Here's a list of changes per release in Qt5 dev cycle.

@papioara
Copy link
Contributor

Ah, ok - I was not a 100% sure. Just one little correction: moving from on tab to another (be it in the editor tabs or in the tool tabs like Music View, Documentation browser or Snippets for example, the size is being retained. It's only upon closing and reopening Frescobaldi.

Btw, the Frescobaldi flatpak shows the same behaviour. Maybe I should just be patient and wait for the next Frescobaldi version and see if it's still there...

@jeanas
Copy link
Member

jeanas commented Mar 1, 2023

If I use "Music > Save current view settings as default", as advised by Wilbert in his initial comment, then after closing and restarting Frescobaldi, I get a code editor and a music view with the same width as I had previously.

Reading the code, "Remember view settings per document" only affects the PagedView instance (which holds e.g., zoom, which rectangle of the document is being viewed, etc.), so I don't see how this can possibly modify the layout width distribution between the editor and the music view. Not sure when it changed, but is this really important? Do you really want to have the music view width remembered per file, or are you just seeking to set the default for all files, in which case "Save current view settings" should work?

@papioara
Copy link
Contributor

papioara commented Mar 2, 2023

I have done some further research into Frescobaldi on my machine. I had the idea to compare the Frescobaldi behaviour on different computers and Linux flavors in my house. And to be sure we talk about the same feature: yes, I mean the one which can be controlled by Music > Save current view settings.

Candidate one:
Frescobaldi 2.0.11 on Linux Mint 17.3 Rosa
On launch I get a window split half and half, and there is no 'Save current view settings' yet.
When I set it to Full Screen by pressing F11, the half and half split does not change.

Candidate two:
A Laptop with KaOS, a rolling release radically using Qt for the graphical appearance (that's what they say about it)
Frescobaldi 3.2
On launch I also get a 50/50 window which stays like this when pressing F11.
When in window mode I choose 'Maximise', the Music View pane goes full-screen and can be toggled back by choosing 'Maximise' again.
When I manually change (in window mode) the 50/50 ratio to something else, choose 'Save current view settings' from the menu and quit Frescobaldi, and when I restart it, it stubbornly reverts to 50/50. Tried several times.

Candidate three:
My work machine with Mint 21.1 Cinnamon LTS
In window mode, on launch, I get a 50/50 window as well, and like on the laptop, I can change the ratios to whatever I like (choosing 'Save current view settings' every time afterwards, but on restarting Frescobaldi I always get my 50/50 split back. I do not mind this so far, because this is what I prefer anyway. It's just for the record.
When I choose 'Maximise' from the menu, the Music View pane surprisingly is detached, and a second 'Maximise' does not toggle it back. You can only do this by a mouse click.

And now we actually come to what exactly I was complaining about, and what I have not sufficiently been able to make clear - all my fault:
When I go to full-screen pressing F11, Frescobaldi follows suit, but different from the other machines and versions I have examined, it does not keep the 50/50 ratio, but goes to something like 65/35.
Since I work on a 1920x1200 monitor, the editor window is way too wide, and the Music View pane too narrow. Using Frescobaldi in full-screen mode on a big monitor is very convenient, but it is annoying to have to manually correct the split every time you fire up Frescobaldi. It is certainly not the end of the world, and I can live with it if I have to. Frescobaldi is too good a tool and offers so much Lilypond convenience that I certainly won't stop using it because of this little flaw.

But, of course I wanted to put the question in order to see, if there is something I may have overlooked, so I can change it. Or maybe this is a little bug which could be fixed at some point. I am sure you will understand...

@fedelibre
Copy link
Member

If I use "Music > Save current view settings as default", as advised by Wilbert in his initial comment, then after closing and restarting Frescobaldi, I get a code editor and a music view with the same width as I had previously.

I don't. Perhaps there's some needed setting in the preferences to make it work?
I have Start with no session in the Preferences... Don't know if it matters.

@papioara
Copy link
Contributor

papioara commented Mar 3, 2023

I tried that one as well, but it did not have the desired effect either. I think that in the meantime I have gone through and tried all possible options and settings available. The fact is that at least on my system Frescobaldi 'wants' to keep the same width of the Music View part of its window. I even have taken a ruler for verification. It does not matter what size your window is - small, full-size of full-screen: whatever you set and whatever you change manually, it always reverts to the same width after restart.

So I would rather call this some kind of a bug and not some overlooked or ignored setting. It forces the user who wants to work full-screen to manually adjust the Music View every time Frescobaldi is fired up. I have also seen this behaviour in version 3.1.3 on MX Linux by the way - so it may have come with version 3 maybe, because I know for sure that it has not been like this in earlier versions.

@jeanas
Copy link
Member

jeanas commented Mar 3, 2023

OK, I understand now that actually, for me, the proportion between the editor and the music view remains the same between runs, regardless of whether I use "Save current view settings as default". Probably something my desktop environment does? I had never noticed it, but I see it on other apps as well (namely Nautilus and Evolution, though not GNOME Terminal). I am using Fedora 37, with GNOME 3, and Wayland.

After doing "Save current view settings as default", the [musicview] section that appears in my ~/.config/frescobaldi/frescobaldi.conf is

[musicview]
continuousMode=true
orientation=2
pageLayoutMode=single
rotation=0
viewMode=0
zoomFactor=1

which indeed doesn't contain any code/music layout ratio information.

@ksnortum
Copy link
Contributor

ksnortum commented Mar 3, 2023 via email

@jeanas
Copy link
Member

jeanas commented Mar 3, 2023

It's not an "on / off" state, it's a one-time action.

@ksnortum
Copy link
Contributor

ksnortum commented Mar 3, 2023 via email

@papioara
Copy link
Contributor

papioara commented Mar 6, 2023

My Frescobaldi config has this in [musicview]:

[musicview]

continuousMode=true
document_properties=false
editinplace\dialog\size=@Size(361 195)
kinetic_scrolling=true
magnifier\scale=300
magnifier\size=300
newer_files_only=true
orientation=2
pageLayoutMode=single
rotation=0
show_scrollbars=true
sync_cursor=true
viewMode=0
zoomFactor=0.5

Would it be possible to add an entry manually if one knew how to put it for Frescobaldi?

@jeanas
Copy link
Member

jeanas commented Mar 6, 2023

You can edit this file however you want, but if Frescobaldi's code does not read the setting, it won't do anything...

@papioara
Copy link
Contributor

papioara commented Mar 6, 2023

Yes, I guess so, but I have no idea about the proper syntax. Many entries are pretty self-explaining, but what for instance would viewMode=0 mean? I mean, of course I could play around with values. Could someone tell me what the syntax is called? Is it Python? If I knew a name, I could maybe try and learn to understand what Frescobaldi might expect as instruction.

@jeanas
Copy link
Member

jeanas commented Mar 6, 2023

https://doc.qt.io/qt-6/qsettings.html#section-and-key-syntax? I don't think a simple setting for the code/PDF ratio exists, but feel free to prove me wrong. I think we probably need to use something like saveDialogSize but I'm not sure.

@fedelibre
Copy link
Member

According to this, the setting is supposed to be saved within the musicview section of the configuration file.

My frescobaldi.conf has this:

[musicview]
continuousMode=true
orientation=2
pageLayoutMode=single
rotation=0
viewMode=0
zoomFactor=1

No information about pane sizes.

@papioara
Copy link
Contributor

papioara commented Mar 6, 2023

I have looked into all your proposals and I offer you a warm thank you for your assistance and effort, but I have decided to give up on it for now - I lack too much background to really be able to find a solution without investing quite a bit of time.

Hoping that in a future release this will be fixed/added I will continue to manually adjust the ratio in full-screen mode. After all this is a minor thing. Do you think that it is worth a feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants