Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI synth reset sets program change to 0 #1392

Open
wbsoft opened this issue Sep 12, 2021 · 2 comments
Open

MIDI synth reset sets program change to 0 #1392

wbsoft opened this issue Sep 12, 2021 · 2 comments

Comments

@wbsoft
Copy link
Collaborator

wbsoft commented Sep 12, 2021

Reported by a user: Frescobaldi always sets the MIDI instrument to the Grand Piano, even if the LilyPond-generated MIDI file specifies no program change at all. This breaks the situatiuon where the user sets an instrument manually and then wants Frescobaldi to play it.

Solution: not send a program change on reset? Or even no reset at all?

@rdoursenaud
Copy link
Contributor

The MIDI specification insists that such messages shouldn’t be sent automatically but upon user request instead.

I’d suggest to make this feature a "Panic" button inside the MIDI player instead of sending it automatically.
(and/or)
This could also be a toggle switch like Steinberg Cubase on Atari used to do that enables/disables calling the reset before playing.

@tsgouros
Copy link

tsgouros commented Dec 29, 2021

Hello: I'm the user who originally reported this. Can I suggest simply commenting out the program change on line 53 of frescobaldi_app/midifile/output.py?

That way it would conform to the midi spec while you figure out how to add a button to the player?

In truth, I'm not sure the reset needs to be called in frescobaldi_app/miditool/player.py, line 50, so you could always comment it out there, or add a flag to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants