Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String tunings autocompletion #1298

Open
fedelibre opened this issue May 3, 2020 · 0 comments · May be fixed by #1487
Open

String tunings autocompletion #1298

fedelibre opened this issue May 3, 2020 · 0 comments · May be fixed by #1487

Comments

@fedelibre
Copy link
Member

python-ly doesn't have a list of the string tunings defined in LilyPond ly/string-tunings-init.ly file.
Adding the list to python-ly is easy. But adding the completion in Frescobaldi is a bit more difficult.
(I've played with files analyzer.py and completiondata.py and I think I was close to make it work, but I did not understand how the classes in analyzer.py work)

This is an example of string tuning:

\new TabStaff \with {
  stringTunings = #guitar-dadgad-tuning
}

Here's the list to be added to python-ly words.py, so it doesn't get lost:

string_tunings = (
    'guitar-tuning',
    'guitar-seven-string-tuning',
    'guitar-drop-d-tuning',
    'guitar-drop-c-tuning',
    'guitar-open-g-tuning',
    'guitar-open-d-tuning',
    'guitar-dadgad-tuning',
    'guitar-lute-tuning',
    'guitar-asus4-tuning',
    'bass-tuning',
    'bass-four-string-tuning',
    'bass-drop-d-tuning',
    'bass-five-string-tuning',
    'bass-six-string-tuning',
    'mandolin-tuning',
    'banjo-open-g-tuning',
    'banjo-c-tuning',
    'banjo-modal-tuning',
    'banjo-open-d-tuning',
    'banjo-open-dm-tuning',
    'ukulele-tuning',
    'ukulele-d-tuning',
    'tenor-ukulele-tuning',
    'baritone-ukulele-tuning',
    'violin-tuning',
    'viola-tuning',
    'cello-tuning',
    'double-bass-tuning',
)
fedelibre added a commit to fedelibre/frescobaldi that referenced this issue Dec 3, 2022
@fedelibre
Add autocompletion for string tunings
78eaf71 
Fixes frescobaldi#1298
@fedelibre fedelibre linked a pull request Dec 3, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add autocompletion for string tunings fedelibre/frescobaldi
1 participant
@fedelibre