-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider bumping Python version requirement #1508
Comments
Sounds good to me if you are confident everything will hold for 3.7! 👍 |
Will do. |
I asked a question about UTF-8 mode on https://discuss.python.org/t/packaging-python-script-with-utf-8-mode/23813. |
Regarding my comment in #1285, I still cannot recall what the problem was, but I packaged 3.1.3 with Python 3.9, so feel free to bump the requirement up to that version. I'm trying with Python 3.11, let's see if packaging 3.2 works this time... |
OK, thanks! |
From the discuss.python.org thread, it seems that the goal of using UTF-8 mode is incompatible with the goal of making |
I just noticed instances of
with open(filename, 'r'):
, whereencoding="utf-8"
is missing. This means that a system-dependent encoding can be used instead of UTF-8 (see https://peps.python.org/pep-0686/#motivation).The
INSTALL
file states that Frescobaldi requires Python ≥ 3.6. However, Python 3.6 went EOL at the end of year 2021. If we bump the requirement to Python 3.7, we can use Python's UTF-8 mode, which makes UTF-8 encoding the default (and will become the default in Python 3.15, as proposed in PEP 686 linked above). Then we no longer have to care about encodings.Judging from #1285, we cannot bump higher than 3.7 though.
The text was updated successfully, but these errors were encountered: