Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LilyPond overrides with pre-2.18 syntax #1728

Closed
ksnortum opened this issue Jan 15, 2024 · 3 comments
Closed

LilyPond overrides with pre-2.18 syntax #1728

ksnortum opened this issue Jan 15, 2024 · 3 comments

Comments

@ksnortum
Copy link
Contributor

ksnortum commented Jan 15, 2024

As per David Kastrup in the LilyPond users' forum:

Calling

git grep "\\\\override[^=]*#'[a-z]"

in the current Frescobaldi source tree delivers way too many hits.

Search for all "bad" overrides in the code base and bring them up to post-2.18 syntax, for instance:

\override Tie #'thickness = #2

becomes

\override Tie.thickness = #2

And a way should be found to fix any overrides that span line breaks.

@jeanas jeanas closed this as completed in 8f71e31 Jan 15, 2024
@jeanas
Copy link
Member

jeanas commented Jan 15, 2024

Should be fixed. Please reopen if you find a missing spot.

@ksnortum
Copy link
Contributor Author

There's a "clever" one hidden in two lines in clef_treble_8.ly, lines 7 and 8. (Sorry, I don't know how to re-open the issue.)

@jeanas
Copy link
Member

jeanas commented Jan 15, 2024

Ah yes, fixed in b6bc6e8.

(Sorry, I don't know how to re-open the issue.)

Ok, then I guess people without triage access to the repository can't reopen issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants